Add deployment chain RFC by khanhtc1202 · Pull Request #2743 · pipe-cd/pipecd

khanhtc1202 · 2021-11-04T09:42:45Z

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

pipecd-bot · 2021-11-04T09:49:21Z

Code coverage for golang is 32.11%. This pull request does not change code coverage.

docs/rfcs/0007-deployment-flow.md

nghialv · 2021-11-04T10:24:38Z

Still reading the RFC but just left some quick reviews.

pipecd-bot · 2021-11-04T10:54:07Z

Code coverage for golang is 32.11%. This pull request does not change code coverage.

pipecd-bot · 2021-11-04T13:06:52Z

Code coverage for golang is 32.11%. This pull request does not change code coverage.

docs/rfcs/0007-deployment-flow.md

nghialv · 2021-11-05T02:53:45Z

It would be nice if you can add a screenshot of a simple mock page of the "Flows" or "Chains" tab.

docs/rfcs/0007-deployment-flow.md

pipecd-bot · 2021-11-05T05:08:06Z

Code coverage for golang is 32.11%. This pull request does not change code coverage.

khanhtc1202 · 2021-11-05T09:51:55Z

Thanks @nghialv @nakabonne, PTAL when you guys have time 🙆‍♀️

pipecd-bot · 2021-11-05T10:02:51Z

Code coverage for golang is 32.11%. This pull request does not change code coverage.

pipecd-bot · 2021-11-08T05:17:46Z

Code coverage for golang is 32.11%. This pull request does not change code coverage.

docs/rfcs/0007-deployment-chain.md

Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>

pipecd-bot · 2021-11-08T05:34:31Z

Code coverage for golang is 32.11%. This pull request does not change code coverage.

…o add-deployment-flow-rfc

pipecd-bot · 2021-11-08T07:25:31Z

Code coverage for golang is 32.11%. This pull request does not change code coverage.

nghialv · 2021-11-09T03:49:27Z

docs/rfcs/0007-deployment-chain.md

+Use-case <1>: chain of deployments contains multiple application cross kinds
+
+Another typical use-case is when users want to build up some kind of chain such as deploy application to the development environment, then if it's done successfully, deploy that application to the staging and then the production environment.
+


How about following the layout below to be easier to read?

Use-case <1> ... Image 1 Description text for use-case 1 Use-case <2> ... Image 2 Description text for use-case 2 Use-case <3> ... Image 3 Description text for use-case 3

Adopted 🙆‍♀️

nghialv · 2021-11-09T03:52:54Z

docs/rfcs/0007-deployment-chain.md

+
+Or a variant of that requirement, when users want to roll out their applications to their cluster one by one based on its region. As the same below image, the order of the rolling out deployment should be flex, supports both sequential and parallel.
+
+![image](assets/deployment-chain-region.png)


All the application names in this image should be fixed as application-x-region-a, application-x-region-b, ...

addressed by b16dee1

docs/rfcs/0007-deployment-chain.md

Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>

pipecd-bot · 2021-11-09T05:17:47Z

Code coverage for golang is 32.11%. This pull request does not change code coverage.

pipecd-bot · 2021-11-09T05:36:46Z

Code coverage for golang is 32.11%. This pull request does not change code coverage.

pipecd-bot · 2021-11-09T10:48:01Z

Code coverage for golang is 32.11%. This pull request does not change code coverage.

nghialv · 2021-11-09T13:31:31Z

Finally, we can see a nice future for the deployment chain feature.
Great write-up.
/lgtm

nakabonne · 2021-11-10T05:21:49Z

I'm sure this will blow their mind!
/approve

pipecd-bot · 2021-11-10T05:21:52Z

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Add deployment flow RFC

25c1155

pipecd-bot added release-note-none area/docs area/site size/L labels Nov 4, 2021

pipecd-bot requested review from nakabonne and ono-max November 4, 2021 09:42

nghialv reviewed Nov 4, 2021

View reviewed changes

docs/rfcs/0007-deployment-flow.md Outdated Show resolved Hide resolved

nghialv reviewed Nov 4, 2021

View reviewed changes

docs/rfcs/0007-deployment-flow.md Outdated Show resolved Hide resolved

No japanese text

7310712

Add note

ee51d2d

nghialv reviewed Nov 5, 2021

View reviewed changes

docs/rfcs/0007-deployment-flow.md Outdated Show resolved Hide resolved

nakabonne reviewed Nov 5, 2021

View reviewed changes

docs/rfcs/0007-deployment-flow.md Outdated Show resolved Hide resolved

nakabonne reviewed Nov 5, 2021

View reviewed changes

docs/rfcs/0007-deployment-flow.md Outdated Show resolved Hide resolved

Rename

478e1aa

Update deployment chain RFC

fce13e4

khanhtc1202 changed the title ~~Add deployment flow RFC~~ Add deployment chain RFC Nov 5, 2021

Typo

6b6921c

Change image

5dc0a12

nghialv reviewed Nov 8, 2021

View reviewed changes

docs/rfcs/0007-deployment-chain.md Outdated Show resolved Hide resolved

docs/rfcs/0007-deployment-chain.md Outdated Show resolved Hide resolved

nghialv reviewed Nov 8, 2021

View reviewed changes

docs/rfcs/0007-deployment-chain.md Show resolved Hide resolved

khanhtc1202 and others added 2 commits November 8, 2021 12:26

Update docs/rfcs/0007-deployment-chain.md

de07f4e

Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>

Update docs/rfcs/0007-deployment-chain.md

2baf26f

Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>

khanhtc1202 added 3 commits November 8, 2021 16:12

Add examples

58cfaf4

Merge branch 'add-deployment-flow-rfc' of github.com:pipe-cd/pipe int…

0cbd7e5

…o add-deployment-flow-rfc

Add link

240abcc

nghialv reviewed Nov 9, 2021

View reviewed changes

docs/rfcs/0007-deployment-chain.md Outdated Show resolved Hide resolved

Update docs/rfcs/0007-deployment-chain.md

d2672f8

Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>

Fix comments

b16dee1

Update note

4357c76

pipecd-bot added the lgtm label Nov 9, 2021

pipecd-bot added the approved label Nov 10, 2021

pipecd-bot merged commit 751b16a into master Nov 10, 2021

pipecd-bot deleted the add-deployment-flow-rfc branch November 10, 2021 05:29

This was referenced Dec 1, 2021

Update doc for deployment triggering #2867

Merged

Temporarily disable appconfig reporter in Piped #2868

Merged

		Use-case <1>: chain of deployments contains multiple application cross kinds

		Another typical use-case is when users want to build up some kind of chain such as deploy application to the development environment, then if it's done successfully, deploy that application to the staging and then the production environment.


		Or a variant of that requirement, when users want to roll out their applications to their cluster one by one based on its region. As the same below image, the order of the rolling out deployment should be flex, supports both sequential and parallel.

		![image](assets/deployment-chain-region.png)

Conversation

khanhtc1202 commented Nov 4, 2021

Uh oh!

pipecd-bot commented Nov 4, 2021

Uh oh!

Uh oh!

Uh oh!

nghialv commented Nov 4, 2021

Uh oh!

pipecd-bot commented Nov 4, 2021

Uh oh!

pipecd-bot commented Nov 4, 2021

Uh oh!

Uh oh!

nghialv commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pipecd-bot commented Nov 5, 2021

Uh oh!

khanhtc1202 commented Nov 5, 2021

Uh oh!

pipecd-bot commented Nov 5, 2021

Uh oh!

pipecd-bot commented Nov 8, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pipecd-bot commented Nov 8, 2021

Uh oh!

pipecd-bot commented Nov 8, 2021

Uh oh!

nghialv Nov 9, 2021

Choose a reason for hiding this comment

Uh oh!

khanhtc1202 Nov 9, 2021

Choose a reason for hiding this comment

Uh oh!

nghialv Nov 9, 2021

Choose a reason for hiding this comment

Uh oh!

khanhtc1202 Nov 9, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pipecd-bot commented Nov 9, 2021

Uh oh!

pipecd-bot commented Nov 9, 2021

Uh oh!

pipecd-bot commented Nov 9, 2021

Uh oh!

nghialv commented Nov 9, 2021

Uh oh!

nakabonne commented Nov 10, 2021

Uh oh!

pipecd-bot commented Nov 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nghialv commented Nov 5, 2021 •

edited

Loading